remove migrate prop, finish deprecation #3075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
May 19, 2024
| const itemAsArray = [item]; | ||
| if (!migrate) { |
There was a problem hiding this comment.
You can't remove code from public without changing the major version - this should be part of the v8 effort
Comment on lines
-83
to
-91
| "component": "Picker", | ||
| "source": "module-with-deprecations", | ||
| "props": [ | ||
| { | ||
| "prop": "migrate", | ||
| "message": "Please make sure to pass the 'migrate' prop.", | ||
| "isRequired": true | ||
| } | ||
| ] |
There was a problem hiding this comment.
This should be taken as an example, it can stay here even after the removal of the migrate prop (or you can add a different example instead; this also fails a test that is run on this package)
|
@M-i-k-e-l closing this PR, this will be the last stage in the refactor, opening for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker refactor - finish prop deprecation.
Finish
migrateprop deprecation, themigrateprop was in prop deprecation error phase.Note: take a look at this PR, I checked that
0value works.Changelog
Picker finish
migrateprop deprecation.Additional info
MDAS - 4195