Fix/segmented control icon spacings #3096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adids1221
reviewed
May 27, 2024
| @@ -112,7 +112,7 @@ const Segment = React.memo((props: SegmentProps) => { | |||
| onLayout?.(index, event); | |||
| }, | |||
| [onLayout, index]); | |||
|
|
|||
| const labelAndIconSpacings = !!iconSource && (iconOnRight ? styles.rightMargin : styles.leftMargin); | |||
There was a problem hiding this comment.
I think you should rename it since the Spacing is going to the Text component.
labelMargins or something like that WDYT ?
There was a problem hiding this comment.
Hmm, I dont see much difference. Yours is shorter so we can use that.
nitzanyiz
added
the
Important for Next Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added spacing between icon and label in the
SegmentedControlsegments.Changelog
SegmentedControl - Added S1 spacings between icon and label.
Additional info
MADS-4239