TextField - new features: helperText and validationIcon #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
May 28, 2024
| @@ -74,7 +76,7 @@ const TextField = (props: InternalTextFieldProps) => { | |||
| enableErrors, // TODO: rename to enableValidation | |||
| validationMessageStyle, | |||
| validationMessagePosition = ValidationMessagePosition.BOTTOM, | |||
| retainValidationSpace = true, | |||
| retainValidationSpace = !helperText, | |||
There was a problem hiding this comment.
Just to make sure I understand
because helperText now renders under the input then we don't need to retain space if it exists?
There was a problem hiding this comment.
Yes. Otherwise there will be a gap btw the input and the helperText
ethanshar
approved these changes
May 28, 2024
| validationMessage="This field is required" | ||
| containerStyle={{flexGrow: 1}} | ||
| validationMessage="This field is required. That means you have to enter some value" | ||
| containerStyle={{width: 300}} |
There was a problem hiding this comment.
It's not a good fix, we can't expect the user to do this, so we need to understand better the issue maybe it'll lead us to a problem in the TextField implmentation
We can do it separately since it's not related to the PR as you said
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField - new features: helperText and validationIcon
Changelog
TextField - new features: helperText and validationIcon
Additional info
ticket 4173