SegmentedControl - fixed Outline sometimes renders as a line #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
May 28, 2024
| @@ -138,8 +135,8 @@ const SegmentedControl = (props: SegmentedControlProps) => { | |||
| const animatedSelectedIndex = useSharedValue(initialIndex); | |||
| const segmentsStyle = useSharedValue([] as {x: number; width: number}[]); | |||
| // const shouldResetOnDimensionsOnNextLayout = useRef(false); // use this flag if there bugs with onLayout being called more than once. | |||
There was a problem hiding this comment.
Can we remove all the code related to 'shouldResetOnDimensionsOnNextLayout'?
|
@nitzanyiz Looks good. Just a small note o the commented code |
Inbal-Tish
changed the title
Inbal-Tish
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SegmentedControl outline sometimes renders a straight line and doesn't cover entire segment. Changed the height dimension on the outline to also be a shared value.
Changelog
SegmentedControl - Fix outline sometimes renders as a straight line.
Additional info
MADS-4246