Support passing imageStyle when rendering internally ImageBackground #3131
Conversation
| @@ -183,6 +185,13 @@ class Image extends PureComponent<Props, State> { | |||
| return this.getVerifiedSource(source); | |||
| } | |||
|
|
|||
| getImageStyle = () => { | |||
There was a problem hiding this comment.
I think we should wrap this with useMemo, also this.shouldUseImageBackground() should be memoized since we are using it's value more than once and store it's value into variable.
WDYT ?
There was a problem hiding this comment.
WDYM?
First of all, notice this is a class component, we can't use useMemo here.
Also there's no point in memoizing, notice I return this return borderRadius ? [{borderRadius}, imageStyle] : imageStyle; so if a borderRadius was passed the style will be dynamic anyway and if it wasn't passed, I am just passing the imageStyle prop that the user has passed.
as for this.shouldUseImageBackground() we don't store its value anywhere.. it's just a util method. where do we store its value in a variable?
There was a problem hiding this comment.
I had some mistake here my bad.
About the getImageStyle you are right since the return statement will return imageStyle.
Description
Pass
imageStyleto Image component when internally it renders ImageBackground (whenever we render children inside the Image)This fix some issues where image styling is not being passed to the Image that rendered by ImageBackground component
See reference in React Native docs
Changelog
Fix nesting image style props in Image component with children (overlay, content)..
Additional info
ticket 4290