Skip to content

TextField Screen snapshot test #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Jun 19, 2024

Description

TextField Screen snapshot test.
Related PR

Changelog

TextField Screen snapshot test.

Additional info

MADS - 4303

const {KeyboardAwareInsetsView} = Keyboard;
const priceFormatter = Intl.NumberFormat('en-US');

loadDemoConfigurations();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using loadDemoConfigurations because in the TextFieldScreen we are using Assets after loading them under group demo in this case, getting an error while building the snapshot/running the test when not running loadDemoConfigurations .

@Inbal-Tish
Copy link
Collaborator

@adids1221 Please edit the title and description of this PR to match the actual issue/change

@adids1221 adids1221 changed the title testing that text field label view wrapper isn't centerV TextField Screen snapshot test Jun 20, 2024
@adids1221 adids1221 changed the base branch from master to infra/TextFieldScreen_cases June 20, 2024 08:38
Base automatically changed from infra/TextFieldScreen_cases to master June 20, 2024 08:40
@Inbal-Tish
Copy link
Collaborator

@adids1221 Is the snapshot for the TextFiled screen updated with the last changes to the screen?

@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish Jun 24, 2024
@adids1221
Copy link
Contributor Author

@Inbal-Tish yes

@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 Jun 24, 2024
@Inbal-Tish Inbal-Tish merged commit a39d733 into master Jun 24, 2024
1 check passed
@Inbal-Tish Inbal-Tish deleted the infra/textField_label_wrapper_centerV_testing branch June 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants