-
Notifications
You must be signed in to change notification settings - Fork 734
bugfix: remove TabController.TabBar defaultProps, use JavaScript default parameters instead #3155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: remove TabController.TabBar defaultProps, use JavaScript default parameters instead #3155
Conversation
…ult parameters instead.
@crazyshakalaka Hi. Thank you for your contribution! What bug are you fixing with this change? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, running into this a lot lately.
@Inbal-Tish / can someone approve this? I'd love to be able to have this change, errors have been getting noisy lately |
Thank you, It's my honor to be able to help everyone |
I also hope to have it fixed as soon as possible |
@Inbal-Tish Ping |
@crazyshakalaka can you add @Inbal-Tish as reviewer on this PR? |
@Inbal-Tish Hello |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thank you for your contribution
bugfix: remove TabController.TabBar defaultProps, use JavaScript default parameters instead.
Description
Changelog
components: TabBar
code: remove TabBar.defaultProps
Additional info
issue: #3154