Skip to content

Export emojis as const #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2024
Merged

Export emojis as const #3164

merged 3 commits into from
Jul 4, 2024

Conversation

nitzanyiz
Copy link
Collaborator

Description

Added as const to the emojis so the string will be literal and not just any string.

Changelog

N/A

Additional info

MADS-4306

@nitzanyiz nitzanyiz requested a review from M-i-k-e-l July 4, 2024 10:22
@nitzanyiz nitzanyiz changed the title Fix/emojis as const Export emojis as const Jul 4, 2024
@M-i-k-e-l M-i-k-e-l merged commit 4232371 into master Jul 4, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the fix/emojisAsConst branch July 4, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitzanyiz @M-i-k-e-l