SortableGridList - Order items by index #3171
Conversation
nitzanyiz
changed the title
| const onOrderChange = jest.fn(); | ||
| const renderTree = render(<Testcase onOrderChange={onOrderChange} orderItemsByIndex/>); | ||
| const driverItem = useDraggableDriver(useComponentDriver({renderTree, testID: itemsTestId('0')})); | ||
| driverItem.drag(150); // Items height is 50 but dragging 100 doesn't work for some reason. 150 works and drags one row down. |
There was a problem hiding this comment.
You might want to create a driver
There was a problem hiding this comment.
I'm not sure what the calculation for the drag is. I used 150 because it worked but I don't know If I can make a driver that will be correct for all cases.
There was a problem hiding this comment.
You can look at SortableListItem.driver.new.ts; even if it's not perfect, it's better than nothing
There was a problem hiding this comment.
In the SortableListItem we have a default height for the items so its easy to calculate. Also the widths here are calculated based on the props. I don't really think we need to invest much time in this currently tbh. We can come back to this some other time.
There was a problem hiding this comment.
You've added tests, so it seems logical to add a driver...
We will probably never have time to refactor this...
There was a problem hiding this comment.
We'll probably get to this if the component is used more
There was a problem hiding this comment.
How do you intent to measure usage?
There was a problem hiding this comment.
Channel bugs and questions i guess
ethanshar
added
the
Important for Next Release
| const onOrderChange = jest.fn(); | ||
| const renderTree = render(<TestCase onOrderChange={onOrderChange} orderByIndex/>); | ||
| const driverItem = useDraggableDriver(useComponentDriver({renderTree, testID: itemsTestId('0')})); | ||
| driverItem.drag(150); // Items height is 50 but dragging 100 doesn't work for some reason. 150 works and drags one row down. |
There was a problem hiding this comment.
drag(300) also "works" - any idea why?
Description
Added option for SortableGridList to reorder the items by their index (instead of by replacing locations).
Changelog
SortableGridList - New prop orderByIndex. adds support for reordering by index.
Additional info
MADS-4277