Separate icon color passed in Button from icon style #3180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jul 17, 2024
Inbal-Tish
reviewed
Jul 17, 2024
| @@ -124,6 +124,17 @@ class Button extends PureComponent<Props, ButtonState> { | |||
| return color; | |||
| } | |||
|
|
|||
| getIconColor(): string | undefined { | |||
| const {disabled} = this.props; | |||
| let tintColor = this.getLabelColor(); | |||
There was a problem hiding this comment.
That ignores the tintColor passed in iconStyle, no?
There was a problem hiding this comment.
no, passing iconStyle is always prioritized and it's include in the getIconStyle method
getIconColor is basically responsible for our logic that returns the icon color
There was a problem hiding this comment.
Wait. You mean it is prioritized in the Icon component because you now override the style with props.style, right?
Inbal-Tish
approved these changes
Jul 17, 2024
ethanshar
added a commit
that referenced
this pull request
Jul 17, 2024
* Separate icon color passed in Button from icon style * Update snapshot tests * Add more examples and tests for icon color in Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the icon color we pass in Button from the icon style object.
This allows up to pass iconColor to the
tintColorprop and allow the user to override it color properlyChangelog
Fix issue with Button's icon color not being overridden when passing
iconProps/iconStyleAdditional info