Skip to content

Avoid memoizing render textfield in Picker #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Avoid memoizing render textfield in Picker #3181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/components/picker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
}
};

const renderTextField = useCallback(() => {
const renderTextField = () => {
return renderInput ? (
// @ts-expect-error - hopefully will be solved after the picker migration ends
renderInput(value, label)
Expand All @@ -218,17 +218,7 @@ const Picker = React.forwardRef((props: PickerProps, ref) => {
{pickerInnerInput}
</TextField>
);
}, [
renderInput,
pickerRef,
propsByFieldType,
containerStyle,
labelStyle,
accessibilityInfo,
label,
pickerInnerInput,
testID
]);
};

const expandableModalContent = useMemo(() => {
const useItems = useWheelPicker || propItems;
Expand Down