TextField - add margin btw bottom elements and char counter #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
changed the title
Inbal-Tish
added
the
Important for Next Release
|
@Inbal-Tish any related ticket ? The code looks good, I'm just not sure where the margin is coming from. |
We need the margin since it's defined in the guidelines and so the validationMassage / helperTest won't stick to the charCounter - I fixed the condition to reflect that. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField - add margin btw bottom elements and char counter, adding tests to validationMessage change
Changelog
TextField - add margin btw bottom elements and char counter, adding tests to validationMessage change
Additional info