GridView - fix after gridListIItem change (#3001) #3215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adids1221
reviewed
Aug 20, 2024
| {imageProps && <Image style={itemSize} {...imageProps} customOverlayContent={children}/>} | ||
| {imageProps && ( | ||
| <View style={[{borderRadius: imageProps?.borderRadius}, itemSize]}> | ||
| <Image {...imageProps} style={[itemSize, imageProps?.style]}/> |
There was a problem hiding this comment.
I found that the issue is coming from the style override.
style={itemSize} {...imageProps}
So when the user pass some style via imageProps the size getting override.
I think the better solution will be to fix the style override.
{imageProps && <Image {...imageProps} style={[itemSize, imageProps?.style]} customOverlayContent={children}/>}
There was a problem hiding this comment.
So create a PR, if it works I'll close this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GridView - fix after gridListIItem change (#3001)
Changelog
GridView - fix after gridListIItem change (#3001)
Additional info
None