Fix/tab page nested in scroll view #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Aug 22, 2024
| /** | ||
| * add style properties to tab page | ||
| */ | ||
| tabPageStyle?: StyleProp<ViewStyle>; |
There was a problem hiding this comment.
We usually ride the style prop name and don't create a different, since this is the main style that is passed to the root View in TabPage. Let's rename to style
| !asCarousel && styles.page, | ||
| animatedPageStyle, | ||
| {width: asCarousel ? containerWidth : undefined}, | ||
| tabPageStyle && tabPageStyle |
There was a problem hiding this comment.
You don't need to condition it, if the style is undefined it will be meaningless and do nothing
ethanshar
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added
styleprop toTabPagecomponent to supportTabConrollerinScrollViewChangelog
added style prop to TabPage component to support TabConroller in ScrollView
Additional info