Incubator.Dialog - Fixed content component being created on every render. #3231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng mounts and unmounts
ethanshar
reviewed
Aug 26, 2024
| @@ -49,7 +49,7 @@ const useDialogContent = (props: InternalDialogCloseButtonProps) => { | |||
| return showCloseButton ? [propsContainerStyle, styles.transparent] : propsContainerStyle; | |||
| }, [showCloseButton, propsContainerStyle]); | |||
|
|
|||
| const DialogContent = () => { | |||
| const getDialogContent = () => { | |||
There was a problem hiding this comment.
let's rename it torenderDialogContent because it's a render method (it returns an element)
ethanshar
approved these changes
Aug 26, 2024
nitzanyiz
added a commit
that referenced
this pull request
Aug 26, 2024
…der. (#3231) * fixed DialogContent component being created on every render and casuing mounts and unmounts * rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new useDialogContent hook was creating a component (DialogContent) on every render and then rendering it. This component is a "new" component every time therefore causing the component to render nonstop.
This could also be solved using useMemo but I don't see any use to it since DialogContent has no state.
Changelog
Incubator.Dialog - Fixed content renders.
Additional info
MADS-4444