Skip to content

wheel picker separators code refactor #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

adids1221
Copy link
Contributor

Description

WheelPicker separators was rendered above the AnimatedFlatList, which cause that the separator render over the current item.

example code snippet (from the example screen):

           <WheelPicker
            initialValue={'February'}
            activeTextColor={Colors.$textPrimary}
            inactiveTextColor={Colors.$textNeutralHeavy}
            items={monthItems}
            textStyle={Typography.text60R}
            numberOfVisibleRows={3}
            separatorsStyle={{backgroundColor: Colors.red70}}
          />

Changelog

WheelPicker separators render below the list items.

Additional info

#3028

@M-i-k-e-l M-i-k-e-l merged commit c708c6a into master Sep 1, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the fix/wheelPicker_separator_issue branch September 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants