Support rendering TabController inside a ScrollView (with a header) #3235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
Inbal-Tish
reviewed
Sep 3, 2024
| @@ -55,6 +55,7 @@ export function registerScreens(registrar) { | |||
| registrar('unicorn.components.StepperScreen', () => require('./StepperScreen').default); | |||
| registrar('unicorn.components.SwitchScreen', () => require('./SwitchScreen').default); | |||
| registrar('unicorn.components.TabControllerScreen', () => require('./TabControllerScreen').default); | |||
| registrar('unicorn.components.TabControllerWithStickyHeaderScreen', () => require('./TabControllerWithStickyHeaderScreen').default); | |||
There was a problem hiding this comment.
You need to wrap screen with gestureHandlerRootHOC
|
@ethanshar Looks great. Left a small comment |
Inbal-Tish
reviewed
Sep 3, 2024
| <TabController items={items} nestedInScrollView> | ||
| <ScrollView | ||
| // stickyHeaderHiddenOnScroll | ||
| stickyHeaderIndices={[0, 1]} |
There was a problem hiding this comment.
Child 0 won't be sticky here so you can also pass only '[1]' as index
Inbal-Tish
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering TabController layout inside a ScrollView, especially when having a header (see new example screen)
the layout doesn't work well
In order to support that I added the
nestedInScrollViewprop that handles the TabPages layout differentlyChangelog
Support rendering TabController inside a ScrollView (with a header) by passing
nestedInScrollViewAdditional info