Move from npmignore to files in order to fix the native components packaging #3319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like our native components are broken for a while, this fixes the issue.
We've moved to node 20 from 16 (PR) and for some reason it changed the files included in our package - it removed all the native files (
iosandandroidfolders underlib).I've tried to find the relevant change and it is in node 17, but I did not see anything that seemed relevant in the release notes.
Changing to
filesand removing thenpmignoresolved the issue.Please look for anything I've missed in the new
files🙏Changelog
Move from npmignore to files in order to fix the native components packaging
Additional info
None