Skip to content

ColorPicker.Dialog exporting ColorPickerDialog #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

ColorPicker.Dialog exporting ColorPickerDialog #3324

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8510dd
ColorPicker.Dialog exporting ColorPickerDialog
adids1221 Oct 28, 2024
1a2d742
ColorPicker use ComponentStatics
adids1221 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/colorPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ const ColorPicker = (props: Props) => {
};

ColorPicker.displayName = 'ColorPicker';
ColorPicker.Dialog = ColorPickerDialog;

export default asBaseComponent<Props>(ColorPicker);
export default asBaseComponent<Props, {Dialog: typeof ColorPickerDialog}>(ColorPicker);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider setting the static types like this (like we do in Button component)

ComponentStatics<typeof ColorPicker>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed


const plusButtonContainerWidth = SWATCH_SIZE + 20 + 12;
const plusButtonContainerHeight = 92 - 2 * SWATCH_MARGIN;
Expand Down