SearchInput component #3530
Merged
SearchInput component #3530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adids1221
changed the title
Inbal-Tish
reviewed
Mar 31, 2025
Inbal-Tish
reviewed
Mar 31, 2025
Inbal-Tish
reviewed
Mar 31, 2025
Inbal-Tish
reviewed
Mar 31, 2025
Inbal-Tish
reviewed
Mar 31, 2025
Inbal-Tish
reviewed
Apr 1, 2025
src/components/searchInput/types.ts
Outdated
| /** | ||
| * custom loader element | ||
| */ | ||
| renderLoaderElement?: (props?: any) => React.ReactElement; |
There was a problem hiding this comment.
customLoader / loaderElement, I don't think you need to pass back the props here
There was a problem hiding this comment.
You didn't change the prop here at all, not the name and not the type... why is it a function if you don't return anything?
There was a problem hiding this comment.
Changed to customLoader: React.ReactElement.
Function is not relevant here.
Inbal-Tish
reviewed
Apr 1, 2025
Inbal-Tish
reviewed
Apr 1, 2025
Inbal-Tish
reviewed
Apr 1, 2025
Inbal-Tish
reviewed
Apr 2, 2025
Inbal-Tish
reviewed
Apr 2, 2025
Inbal-Tish
reviewed
May 7, 2025
Inbal-Tish
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New SearchInput component
Snapshot version:
7.39.0 - 6623Changelog
New SearchInput component
Additional info
None