Dev tab - Don't render empty sections or the tab #3600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no Dev tab without props
ethanshar
reviewed
Mar 12, 2025
Comment on lines
+63
to
+68
| const api = component.props; | ||
| const tabsArray = api ? [...tabs, devTab] : tabs; | ||
|
|
||
| // TODO: align Tabs bottom border with TabItem's selected indication line | ||
| if (tabs) { | ||
| return <Tabs className="main-tabs">{getTabItems([...tabs, devTab])}</Tabs>; | ||
| return <Tabs className="main-tabs">{getTabItems(tabsArray)}</Tabs>; |
There was a problem hiding this comment.
If we remove Dev tab based on props, it won't render things like notes and tips, no?
Which component/page has this issue (has no api)?
There was a problem hiding this comment.
That's why I based it on the props - that the most important feature that without it I don't think we need the tab.
Can you think of a case where we don't have props but need to display the extend/modifiers/snippet?
There was a problem hiding this comment.
Not really, approving, worse case we'll change it
ethanshar
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dev tab - Don't render empty sections or the tab:
No usage without snipper, no banner without description and no Dev tab without props
Changelog
Dev tab - Don't render empty sections or the tab
Additional info