Skip to content

Refactor asset imports to remove unnecessary default exports #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/assets/extractDimensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function createIndexFile(sourcePath, targetPath, fileType) {

content += ` get ${propertyName}() {\n`;
// eslint-disable-next-line max-len
content += ` return {uri: require('./${file}').default, width: ${dimensions.width}, height: ${dimensions.height}};\n`;
content += ` return {uri: require('./${file}'), width: ${dimensions.width}, height: ${dimensions.height}};\n`;
content += index === files.length - 1 ? ` }\n` : ` },\n`; // Conditional check for the last file
});

Expand Down
32 changes: 16 additions & 16 deletions src/assets/internal/icons/index.web.js
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
export const icons = {
get check() {
return {uri: require('./check.png').default, width: 21, height: 15};
return {uri: require('./check.png'), width: 21, height: 15};
},
get checkMarkSmall() {
return {uri: require('./checkMarkSmall.png').default, width: 16, height: 16};
return {uri: require('./checkMarkSmall.png'), width: 16, height: 16};
},
get checkSmall() {
return {uri: require('./checkSmall.png').default, width: 24, height: 24};
return {uri: require('./checkSmall.png'), width: 24, height: 24};
},
get chevronDown() {
return {uri: require('./chevronDown.png').default, width: 16, height: 16};
return {uri: require('./chevronDown.png'), width: 16, height: 16};
},
get exclamationSmall() {
return {uri: require('./exclamationSmall.png').default, width: 16, height: 16};
return {uri: require('./exclamationSmall.png'), width: 16, height: 16};
},
get minusOutline() {
return {uri: require('./minusOutline.png').default, width: 32, height: 32};
return {uri: require('./minusOutline.png'), width: 32, height: 32};
},
get minusOutlineSmall() {
return {uri: require('./minusOutlineSmall.png').default, width: 24, height: 24};
return {uri: require('./minusOutlineSmall.png'), width: 24, height: 24};
},
get minusSmall() {
return {uri: require('./minusSmall.png').default, width: 16, height: 16};
return {uri: require('./minusSmall.png'), width: 16, height: 16};
},
get plusOutline() {
return {uri: require('./plusOutline.png').default, width: 32, height: 32};
return {uri: require('./plusOutline.png'), width: 32, height: 32};
},
get plusOutlineSmall() {
return {uri: require('./plusOutlineSmall.png').default, width: 24, height: 24};
return {uri: require('./plusOutlineSmall.png'), width: 24, height: 24};
},
get plusSmall() {
return {uri: require('./plusSmall.png').default, width: 16, height: 16};
return {uri: require('./plusSmall.png'), width: 16, height: 16};
},
get search() {
return {uri: require('./search.png').default, width: 24, height: 24};
return {uri: require('./search.png'), width: 24, height: 24};
},
get x() {
return {uri: require('./x.png').default, width: 17, height: 16};
return {uri: require('./x.png'), width: 17, height: 16};
},
get xFlat() {
return {uri: require('./xFlat.png').default, width: 16, height: 16};
return {uri: require('./xFlat.png'), width: 16, height: 16};
},
get xMedium() {
return {uri: require('./xMedium.png').default, width: 24, height: 24};
return {uri: require('./xMedium.png'), width: 24, height: 24};
},
get xSmall() {
return {uri: require('./xSmall.png').default, width: 16, height: 16};
return {uri: require('./xSmall.png'), width: 16, height: 16};
}
};
16 changes: 8 additions & 8 deletions src/assets/internal/images/index.web.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
export const images = {
get gradient() {
return {uri: require('./gradient.png').default, width: 56, height: 2};
return {uri: require('./gradient.png'), width: 56, height: 2};
},
get gradientOverlay() {
return {uri: require('./gradientOverlay.png').default, width: 76, height: 48};
return {uri: require('./gradientOverlay.png'), width: 76, height: 48};
},
get gradientOverlayHigh() {
return {uri: require('./gradientOverlayHigh.png').default, width: 1, height: 297};
return {uri: require('./gradientOverlayHigh.png'), width: 1, height: 297};
},
get gradientOverlayLow() {
return {uri: require('./gradientOverlayLow.png').default, width: 1, height: 297};
return {uri: require('./gradientOverlayLow.png'), width: 1, height: 297};
},
get gradientOverlayMedium() {
return {uri: require('./gradientOverlayMedium.png').default, width: 1, height: 297};
return {uri: require('./gradientOverlayMedium.png'), width: 1, height: 297};
},
get hintTipMiddle() {
return {uri: require('./hintTipMiddle.png').default, width: 20, height: 7};
return {uri: require('./hintTipMiddle.png'), width: 20, height: 7};
},
get hintTipSide() {
return {uri: require('./hintTipSide.png').default, width: 20, height: 24};
return {uri: require('./hintTipSide.png'), width: 20, height: 24};
},
get transparentSwatch() {
return {uri: require('./transparentSwatch.png').default, width: 100, height: 100};
return {uri: require('./transparentSwatch.png'), width: 100, height: 100};
}
};