Improve live code visuals #3654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments; bump version to 3.19.0
There was a problem hiding this comment.
Pull Request Overview
This PR improves the live code visuals by transitioning styling to CSS modules, adding a Prism theme for the live editor, and fixing flex behavior on mobile for the preview container, while also addressing a bug in TableSection when cell data is missing.
- Introduces conditional rendering and safe property access in TableSection to avoid errors.
- Migrates UILivePreview styling from react-native to CSS modules and integrates a new code formatting hook.
- Updates livePreview.tsx to employ CSS modules for improved mobile flex layout.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TableSection.tsx | Adds a null-check for cell data to prevent runtime errors |
| UILivePreview.tsx | Migrates styling to CSS modules and applies a Prism theme |
| useFormattedCode.ts | Updates the initial state for code formatting so it starts as an empty string |
| livePreview.tsx | Adopts CSS modules for the mobile preview container layout |
Files not reviewed (3)
- docuilib/package.json: Language not supported
- docuilib/src/components/UILivePreview.module.scss: Language not supported
- docuilib/src/pages/livePreview.module.css: Language not supported
Comments suppressed due to low confidence (1)
docuilib/src/hooks/useFormattedCode.ts:9
- [nitpick] Using an empty string as the initial value might result in a less informative UI while formatting is in progress; consider providing a placeholder or loading indicator if formatting takes noticeable time.
const [formattedCode, setFormattedCode] = useState<string>('');
M-i-k-e-l
approved these changes
Mar 27, 2025
| display: flex; | ||
| flex-direction: column; | ||
| flex: 1; | ||
| padding: 20px; |
There was a problem hiding this comment.
Don't we want the "user" to decide on the padding? Could we have a screen that wants no padding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve live code visuals
Unrelated, fix minor issue in TableSection to avoid error when missing cell (item) data - this will show empty cell instead of throwing a vague error
Changelog
N/A
Additional info