Skip to content

Fix component support check to handle nested component names #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Fix component support check to handle nested component names #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4df8191
Fix component support check to handle nested component names
adids1221 Mar 27, 2025
74ff923
Refactor component support check to use utility function for improved…
adids1221 Mar 27, 2025
805c6ac
Merge branch 'master' into docs/isComponentSupported_support_nested_c…
ethanshar Mar 28, 2025
2ba051d
bump uilib-docs version to 3.20
ethanshar Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docuilib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "uilib-docs",
"version": "3.19.0",
"version": "3.20.0",
"main": "./src/index.ts",
"scripts": {
"docusaurus": "docusaurus",
Expand Down
6 changes: 2 additions & 4 deletions docuilib/src/components/pageComponents/ContentItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React, {ComponentProps, useCallback, useMemo, useState} from 'react';
import _ from 'lodash';
import '../ComponentPage.module.scss';
import {LiveProvider, LivePreview} from 'react-live';
import styles from './ContentItem.module.scss';
import ReactLiveScope from '../../theme/ReactLiveScope';
import CodeBlock from '../CodeBlock';
import CodeIcon from '../../assets/icons/code';
import {isComponentSupported} from '../../utils/componentUtils';

type ComponentItemProps = {
componentName: string;
Expand Down Expand Up @@ -116,9 +116,7 @@ export const ContentItem = ({item, componentName, showCodeButton, category}: Con
name = `Incubator.${name}`;
}

const isComponentExists = !!_.get(ReactLiveScope, name);

if (isComponentExists) {
if (isComponentSupported(name)) {
return (
<ComponentItem
componentName={name}
Expand Down
5 changes: 2 additions & 3 deletions docuilib/src/utils/componentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import get from 'lodash/get';
import ReactLiveScope from '../theme/ReactLiveScope';

const supportedComponentNames = Object.keys(ReactLiveScope);

export const isComponentSupported = componentName => {
return supportedComponentNames.includes(componentName);
return !!get(ReactLiveScope, componentName);
};