Update button docs #3668
Merged
Update button docs #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Mar 31, 2025
| @@ -135,7 +135,7 @@ | |||
| { | |||
| "name": "enableShadow", | |||
| "type": "boolean", | |||
| "description": "Control shadow visibility (iOS-only)" | |||
| "description": "Control shadow visibility" | |||
There was a problem hiding this comment.
This should be changes in the ts file as well
| @@ -217,15 +222,6 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
You kept the Full-Width Vs. Floating Button section in the UX Guidelines
There was a problem hiding this comment.
I think we can keep it, FloatingButton is available in public
I just didn't want to be in this component types, cause it's a different componetn
| @@ -297,19 +284,7 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "title": "Inverted", | |||
There was a problem hiding this comment.
I feel like you can leave the Inverted.
If you do return it then there's an Inverted section under Icon Button that was removed.
If not, there's a section below about Inverted that's still there.
There was a problem hiding this comment.
Ok, I will revert the changes and return inverted
M-i-k-e-l
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update button docs, remove stuff that are not relevant to public docs
I did keep some UX guidelines that are still possible to achieve
Changelog
N/A
Additional info