Skip to content

Timeline - Add testIDs #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 7, 2025
Merged

Timeline - Add testIDs #3706

merged 17 commits into from
May 7, 2025

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Apr 30, 2025

Description

TimeLine component testID prop set to use for testing improvements, passed to the sub components: Line, Point.

Changelog

TimeLine testID prop.

Additional info

None

@adids1221 adids1221 requested a review from Inbal-Tish May 4, 2025 07:43
@Inbal-Tish
Copy link
Collaborator

@adids1221 What I miss most in this PR is a test driver and maybe some tests... WDYT?

@adids1221
Copy link
Contributor Author

@Inbal-Tish I agree, not sure if it should be in this PR.
I'll create new one based on this branch.

@adids1221 adids1221 requested a review from Inbal-Tish May 4, 2025 12:49
@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 May 4, 2025
@adids1221 adids1221 mentioned this pull request May 4, 2025
@Inbal-Tish
Copy link
Collaborator

@Inbal-Tish I agree, not sure if it should be in this PR. I'll create new one based on this branch.

I think the driver should be on the same PR so we can understand the use of these testIDs.

@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish May 4, 2025
@adids1221
Copy link
Contributor Author

@Inbal-Tish I already started new PR, I'll finish the work there and I'll move the file here.

@adids1221
Copy link
Contributor Author

@Inbal-Tish about getPoint in the driver, do you think it should include getIcon & getLabel under Point?

@adids1221
Copy link
Contributor Author

@Inbal-Tish I refactor the driver as we spoke, added some basic sanity test for timeline exists, point with icon/label and custom color, top/bottom lines

@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish May 6, 2025
@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 May 6, 2025
@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish May 6, 2025
@Inbal-Tish Inbal-Tish changed the title Add testID prop to Line, Point, and Timeline components Timeline - Add testIDs May 6, 2025
@adids1221 adids1221 requested a review from Inbal-Tish May 6, 2025 11:25
@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 May 6, 2025
@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish May 6, 2025
@adids1221 adids1221 assigned Inbal-Tish and adids1221 and unassigned adids1221 and Inbal-Tish May 7, 2025
@adids1221 adids1221 requested a review from Inbal-Tish May 7, 2025 08:28
@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 May 7, 2025
@Inbal-Tish Inbal-Tish merged commit 30c77d5 into master May 7, 2025
1 check passed
@Inbal-Tish Inbal-Tish deleted the infra/Timeline_testID branch May 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants