TextField - Right Icon #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-expandable inputs
ethanshar
reviewed
Jul 11, 2019
src/components/inputs/TextField.js
Outdated
| if (this.shouldDisplayRightButton()) { | ||
| const {rightButtonProps} = this.getThemeProps(); | ||
| const tintColor = _.get(rightButtonProps, 'style.tintColor', Colors.blue30); |
There was a problem hiding this comment.
this is kinda weird.
first, accessing to style as an object is not so great, cause it can be a number or an array
second, tintColor is an image style prop, not a button.
maybe to add an explicit prop to rightButtonProps for tintColor or iconColor
ethanshar
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move right icon to text input render to allow on both expandable and non-expandable inputs