Skip to content

Performance improvements #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2019
Merged

Performance improvements #470

merged 6 commits into from
Jul 15, 2019

Conversation

emilisb
Copy link
Member

@emilisb emilisb commented Jul 15, 2019

  • Refactored modifiers (saves up to 1ms per each base component)
  • Do not render selection view on Card component if selected prop is undefined

ethanshar
ethanshar reviewed Jul 15, 2019
View reviewed changes
@ethanshar ethanshar merged commit c08a459 into master Jul 15, 2019
@ethanshar ethanshar deleted the perf-improvements branch December 11, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilisb @ethanshar