Feat/orientation support #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arousel-related components (ActionBar's demo screen, MainScreen)
…ix for Carousel-related components (ActionBar's demo screen, MainScreen)" This reverts commit 0dbe448.
ethanshar
reviewed
Jul 21, 2019
src/helpers/Constants.js
Outdated
| setStatusBarHeight(); | ||
| } | ||
|
|
||
| /* Orientation */ |
There was a problem hiding this comment.
you just pass the callback, instead of wrapping it since you don't pass any params
Dimensions.addEventListener('change', updateConstants);
There was a problem hiding this comment.
I don't understand...
src/helpers/Constants.js
Outdated
| updateConstants(); | ||
| }); | ||
|
|
||
| export function getOrientation() { |
There was a problem hiding this comment.
What about keep an orientation var (like we do for screen width and height) that get update when orientation changes?
Theoretically, the orientation changes only when rotating the device, no need to calculate it each time, right?
ethanshar
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.