Skip to content

Feat/panning fixes #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 31, 2019
Merged

Feat/panning fixes #483

merged 9 commits into from
Jul 31, 2019

Conversation

M-i-k-e-l
Copy link
Collaborator

No description provided.

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar July 24, 2019 12:16
ethanshar
ethanshar reviewed Jul 25, 2019
View reviewed changes
src/components/panningViews/panDismissibleView.js Outdated
@@ -193,8 +210,9 @@ class PanDismissibleView extends PureComponent {
};

onInitAnimationFinished = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change animateToInitialPosition to resetPosition
change onInitAnimationFinished to onResetPositionFinished
forceDismissIsPending change to shouldDismissAfterReset

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/components/panningViews/panDismissibleView.js Outdated
this.initPositions();
const {forceDismissIsPending} = this.state;
const runAfterSetState = forceDismissIsPending ? this.animateDismiss : undefined;
this.initPositions({isAnimating: false, forceDismissIsPending: false}, runAfterSetState);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need isAnimating in state

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it in the state (but I removed shouldDismissAfterReset from the state)

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar July 25, 2019 08:56
ethanshar
ethanshar reviewed Jul 28, 2019
View reviewed changes
src/interactableComponents/drawer/newDrawer.js Outdated
@@ -25,7 +25,8 @@ const ITEM_PROP_TYPES = {

/**
* @description: Drawer Component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed this in master, please remove it from the PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, done

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar July 28, 2019 12:48
@ethanshar ethanshar merged commit 00f29ab into master Jul 31, 2019
@M-i-k-e-l M-i-k-e-l deleted the feat/panning-fixes branch August 7, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar