Fix/Avatar - Refactor to enable dynamic prop change #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArnonZ
commented
Aug 1, 2019
ArnonZ
commented
- Moved all props from StyleSheet to class
ethanshar
reviewed
Aug 4, 2019
src/components/avatar/index.js
Outdated
| if (hasImage) { | ||
| return ( | ||
| <ImageContainer | ||
| animate={animate} | ||
| style={[this.styles.image, imageStyle]} | ||
| style={[this.getContainerStyle(), {...StyleSheet.absoluteFillObject}, imageStyle]} |
There was a problem hiding this comment.
{...StyleSheet.absoluteFillObject}
spreading an object inside an empty object is good as just passing the object.
ethanshar
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.