Add isTablet to Constants #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Aug 8, 2019
src/helpers/Constants.js
Outdated
| @@ -40,6 +40,8 @@ export let screenWidth = width; | |||
| export let screenHeight = height; | |||
| export let isSmallScreen = screenWidth <= 340; | |||
| export let isShortScreen = screenHeight <= 600; | |||
| export const ratio = screenWidth < screenHeight ? screenHeight / screenWidth : screenWidth / screenHeight; | |||
| export const isTablet = Platform.isPad || (ratio < 1.6 && Math.max(screenWidth, screenHeight) >= 900); | |||
There was a problem hiding this comment.
Where did you get the 1.6 ratio limit?
There was a problem hiding this comment.
It was a guesstimation in a Stack-Overflow answer.
There was a problem hiding this comment.
Yes, it worked on the devices I've tested; and I've added the screen size for good measure
Inbal-Tish
reviewed
Aug 8, 2019
src/helpers/Constants.js
Outdated
| @@ -40,6 +40,8 @@ export let screenWidth = width; | |||
| export let screenHeight = height; | |||
| export let isSmallScreen = screenWidth <= 340; | |||
| export let isShortScreen = screenHeight <= 600; | |||
| export const ratio = screenWidth < screenHeight ? screenHeight / screenWidth : screenWidth / screenHeight; | |||
There was a problem hiding this comment.
Why are you exporting ratio?
There was a problem hiding this comment.
I don't need it exported, but thought it might be useful.
Do you want me to remove that? - Or maybe change the name?
There was a problem hiding this comment.
Let's remove the export till we need it and change the name to be more descriptive.
Inbal-Tish
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.