support passing screen width for the hint container #510
Conversation
src/components/hint/index.js
Outdated
| /** | ||
| * The Screen width for the hint container | ||
| */ | ||
| screenWidth: PropTypes.number, |
There was a problem hiding this comment.
I don't understand why you need screenWidth prop? You don't want to listen to orientation change in the component?
There was a problem hiding this comment.
This is for the tablet support with the custom margins
because we define a custom screen width (in private, the margin make the screen shorter), I need a way to declare this width cause the hint container is based on that.
There was a problem hiding this comment.
We read the screen width from the Constants. Why not make the treatment there? That changes the way other components layout for landscape.
There was a problem hiding this comment.
because in the private code the screen width in tablets is different because of the custom margins we have. I need a way to pass this value from the private repo
There was a problem hiding this comment.
Why not get it in onLayout? It should be called in orientation change as well.
There was a problem hiding this comment.
renamed screenWidth to containerWidth
this is for the tablet support