Feat/ColorPicker updates #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ColorPicker_updates # Conflicts: # src/components/colorPicker/ColorPalette.js # src/components/dateTimePicker/index.js
ethanshar
reviewed
Jan 16, 2020
| /** | ||
| * The container margins | ||
| */ | ||
| containerMargins: PropTypes.number, |
There was a problem hiding this comment.
Is this for our tablet margins?
can't we accomplish this with containerStyle?
with TabController.TabBar i used the containerStyle for the tablet margins..
I think it will be better than defining one-app specific props
There was a problem hiding this comment.
How did you extract the margins if, say, user passed 'marginLeft', 'marginRight', 'marginHorizontal', as opposed to 'margins'? Did you check each separately to determine the container width?
There was a problem hiding this comment.
Changed containerMargins to containerWidth.
ethanshar
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.