improve TextField example screen #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jan 14, 2020
| @@ -41,22 +41,22 @@ export default class InputsScreen extends Component { | |||
| message = 'Please enter a valid text'; | |||
| } | |||
| this.setState({error: message}); | |||
There was a problem hiding this comment.
If there is a dedicated screen for validations why not clean this screen from all error examples to keep it simple?
There was a problem hiding this comment.
Cool. So you want to merge it like that or after the cleanup?
There was a problem hiding this comment.
Done. I'll make it more simple in the future, for now I move the error/validation examples
Inbal-Tish
reviewed
Jan 14, 2020
| import {Navigation} from 'react-native-navigation'; | ||
| import {KeyboardAwareInsetsView} from 'react-native-keyboard-tracking-view'; | ||
|
|
||
| class InputValidationsScreen extends Component { |
There was a problem hiding this comment.
Don't you want to add an useTopErrors example? Maybe a toggle button to switch between the top and the bottom error like in the input screen?
Inbal-Tish
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the text field screen to 3
This is just the initial work, but from here we can start re-arrange the input examples better.
It will also help when we'll add e2e tests