Skip to content

Fix for Carousel defaults and example screen #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix for Carousel defaults and example screen #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions demo/src/screens/componentScreens/CarouselScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import _ from 'lodash';
import React, {Component} from 'react';
import {StyleSheet, ScrollView} from 'react-native';
import {Constants, View, Text, Carousel, Image, Card} from 'react-native-ui-lib'; // eslint-disable-line
import _ from 'lodash';
import {Constants, Spacings, View, Text, Carousel, Image} from 'react-native-ui-lib'; // eslint-disable-line

const INITIAL_PAGE = 2;
const WIDTH = Constants.screenWidth - 120;

const INITIAL_PAGE = 2;
const WIDTH = Constants.screenWidth - (Spacings.s5 * 2);
const IMAGES = [
'https://images.pexels.com/photos/1212487/pexels-photo-1212487.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=750&w=1260',
'https://images.pexels.com/photos/1366630/pexels-photo-1366630.jpeg?auto=compress&cs=tinysrgb&dpr=1&w=500',
Expand All @@ -29,16 +29,15 @@ class CarouselScreen extends Component {
render() {
return (
<ScrollView>
<Text text30 margin-20>
Carousel
</Text>
<Text text30 margin-20>Carousel</Text>

<Carousel
migrate
ref={r => (this.carousel = r)}
// loop
onChangePage={index => this.onChangePage(index)}
pageWidth={WIDTH}
// itemSpacings={20}
// itemSpacings={Spacings.s3}
initialPage={INITIAL_PAGE}
containerStyle={{height: 160/* , flex: 1 */}}
pageControlPosition={'under'}
Expand Down Expand Up @@ -106,7 +105,7 @@ const styles = StyleSheet.create({
page: {
flex: 1,
borderWidth: 1,
borderRadius: 4
borderRadius: 8
}
});

Expand Down
3 changes: 2 additions & 1 deletion src/components/carousel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default class Carousel extends BaseComponent {

static defaultProps = {
initialPage: 0,
itemSpacings: 12,
itemSpacings: 16,
pagingEnabled: true
};

Expand Down Expand Up @@ -270,6 +270,7 @@ export default class Carousel extends BaseComponent {
return (
<PageControl
size={6}
spacing={8}
containerStyle={containerStyle}
inactiveColor={Colors.dark60}
color={Colors.dark20}
Expand Down