-
Notifications
You must be signed in to change notification settings - Fork 734
UILib Packages #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+49
−1
Merged
UILib Packages #723
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a891181
Create an entry file for core sub module of rnuilib
ethanshar 7c5435a
Merge branch 'master' into feat/sub_modules
ethanshar 417a371
create a script that generate sub packages
ethanshar 5924a90
add build:packages script
ethanshar 1f271ba
remove core.js
ethanshar 580af37
build separate package per each component
ethanshar ec02d77
cleanup and add proper comments
ethanshar 81a654c
Merge branch 'master' into feat/sub_modules
ethanshar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
const fs = require('fs'); | ||
const _ = require('lodash'); | ||
|
||
const packages = [ | ||
{ | ||
filename: 'keyboard.js', | ||
content: `module.exports = require('./lib/components/Keyboard').default;\n` | ||
}, | ||
{ | ||
filename: 'core.js', | ||
components: ['View', 'Text', 'Image', 'TouchableOpacity', 'Button'] | ||
} | ||
]; | ||
|
||
/* Write custom packages */ | ||
packages.forEach((package) => { | ||
let content = package.content || ''; | ||
|
||
if (package.components) { | ||
content += 'module.exports = {\n'; | ||
package.components.forEach((component) => { | ||
content += `get ${component}() {\n`; | ||
content += `return require('./src/components/${_.camelCase( | ||
component | ||
)}').default;`; | ||
content += `},\n`; | ||
}); | ||
content += '};\n'; | ||
} | ||
|
||
fs.writeFileSync(package.filename, content); | ||
}); | ||
|
||
/* Write all components as separate packages */ | ||
const path = './src/components'; | ||
fs.readdir(path, (err, files) => { | ||
if (!err) { | ||
files | ||
.filter((f) => f !== 'index.js') | ||
.forEach((file) => { | ||
fs.writeFileSync( | ||
`${file}.js`, | ||
`module.exports = require('${path}/${file}').default;\n` | ||
); | ||
}); | ||
} | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use 'components: [keyboard]'? It's clearer and you can add other keyboard components in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at
./lib/components/Keyboard
It already contains all the various Keyboard components we have.
The user will be able to import it like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. mmm... I still think it's clearer to use the same object format, seems less random. Your call.