Fix Carousel jerks in some cases (Jira 372) #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Apr 7, 2020
There was a problem hiding this comment.
@M-i-k-e-l
looking at this change commit message
it says fixes the initialPage for dynamic width
so my guess..
if u have a carousel with an initialPage (I think that’s greater than zero)
and with a page with a custom width (not full-width) there was an issue
I've re-tested this and it looks like it's working well with the change. |
ethanshar
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added at some point for "carousel page width".
I did not find an example that had a problem without these lines - perhaps one of the later commits fixed this issue?
Any chance you remember this? Or any specific cases we had problems with?