Fix/dialog on dismiss #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ethanshar
commented
Apr 25, 2020
ethanshar
commented
- Revert recent changes with onDismiss functionality
- Add parity to Android with Modal's onDismiss callback that was supported only for iOS
M-i-k-e-l
reviewed
Apr 26, 2020
src/components/dialog/index.js
Outdated
| } | ||
| // Parity with iOS Modal's onDismiss | ||
| if (Constants.isAndroid) { | ||
| _.invoke(props, 'onModalDismissed', props); |
There was a problem hiding this comment.
I feel this is risky, a user could have counted on this not working on Android, and now it will, this is a big potential for bugs.
There was a problem hiding this comment.
as discussed, I added a new prop - onDialogDismissed
M-i-k-e-l
reviewed
Apr 26, 2020
| @@ -59,9 +59,13 @@ class Dialog extends BaseComponent { | |||
| */ | |||
| useSafeArea: PropTypes.bool, | |||
| /** | |||
| * Called once the modal has been dissmissed (iOS only) | |||
| * Called once the modal has been dismissed (iOS only) - Deprecated, use onDialogDismissed instead | |||
There was a problem hiding this comment.
Do we want to add a warning?
M-i-k-e-l
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.