Typescript - RadioButton and RadioGroup #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
commented
May 5, 2020
M-i-k-e-l
commented
May 5, 2020
M-i-k-e-l
commented
May 5, 2020
ethanshar
reviewed
May 11, 2020
| @@ -0,0 +1,65 @@ | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
For next migration, make sure to not delete and create new file but to make sure git just rename the files
(similar to how u did for RadioButton file)
It's important for git log history of the files
There was a problem hiding this comment.
I reverted and renamed, but I think it just looks different in GitHub, I see the history locally, can you verify you do to?
ethanshar
reviewed
May 11, 2020
| import TouchableOpacity from '../touchableOpacity'; | ||
| import View from '../view'; | ||
| import Text from '../text'; | ||
| import Image from '../image'; |
There was a problem hiding this comment.
I think u can import as usual but just add //@ts-ignore
There was a problem hiding this comment.
import Image from '../Image'; gives an error
ethanshar
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding some comments in the PR where there's stuff that I'm unsure how to solve and if it should be changed.
Hopefully fixes #759