Skip to content

Fix/Picker + TextField Ui fixes #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 20, 2020
Merged

Fix/Picker + TextField Ui fixes #785

merged 6 commits into from
May 20, 2020

Conversation

ArnonZ
Copy link
Contributor

@ArnonZ ArnonZ commented May 19, 2020 •
edited
Loading

  • Removed unneeded Picker value default typography. TextField defaults to that same typography.
    In addition, this is a blocker for (WOAUILIB-816).
  • Updated TextField's rightIcon bottom padding condition
  • Updated DateTimePicker example screen.

@ArnonZ ArnonZ changed the title Fix/Picker default typography + screen refactor Fix/Picke + TextField Ui fixes May 19, 2020
@ArnonZ ArnonZ changed the title Fix/Picke + TextField Ui fixes Fix/Picker + TextField Ui fixes May 19, 2020
@ArnonZ ArnonZ requested a review from ethanshar May 19, 2020 23:08
ethanshar
ethanshar requested changes May 20, 2020
View reviewed changes
@ArnonZ ArnonZ requested a review from ethanshar May 20, 2020 09:38
@ethanshar ethanshar merged commit e9b5881 into master May 20, 2020
@ArnonZ ArnonZ deleted the fix/picker_ui branch September 21, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnonZ @ethanshar