Skip to content

[Bug] Passing validate prop to input as array makes that input required #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

[Bug] Passing validate prop to input as array makes that input required #799

merged 1 commit into from
Jun 2, 2020

Conversation

Effanuel
Copy link
Contributor

@Effanuel Effanuel commented Jun 2, 2020

Issues:

  • Passing validate={[...]}, makes that input required and adds and additional * to placeholder.

Changes:

  • Fixed wrong parentheses which always returned undefined and always made input required.

@Effanuel Effanuel requested a review from ethanshar June 2, 2020 11:30
@Effanuel Effanuel added the bug a bug in one of the components label Jun 2, 2020
@ethanshar ethanshar merged commit bf433d9 into master Jun 2, 2020
@Effanuel Effanuel deleted the Bug-validateArrayMakesFieldRequired branch June 2, 2020 12:00
ethanshar pushed a commit that referenced this pull request Jun 2, 2020
@Effanuel @ethanshar
Fixed wrong parentheses (#799)
616d131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees
No one assigned
Labels
bug a bug in one of the components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Effanuel @ethanshar