Skip to content

fix issue with how we clean modifiers empty values #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix issue with how we clean modifiers empty values #801

merged 1 commit into from
Jun 2, 2020

Conversation

ethanshar
Copy link
Collaborator

The issue was that _.isEmpty returns true on numbers
and the modifiers container also numbers values (for borderRadius for example)

@ethanshar ethanshar requested a review from M-i-k-e-l June 2, 2020 16:55
@M-i-k-e-l M-i-k-e-l merged commit d02a681 into master Jun 2, 2020
@ethanshar ethanshar deleted the fix/modifiers_cleanup branch July 26, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l