Feat/ColorPicker - preview text style prop #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jun 7, 2020
src/components/colorPicker/index.js
Outdated
| /** | ||
| * Additional styling for the color preview text. | ||
| */ | ||
| previewTextStyle: PropTypes.oneOfType([PropTypes.object, PropTypes.number, PropTypes.array]), |
There was a problem hiding this comment.
the style is meant for the input. call it previewInputStyle
src/components/colorPicker/index.js
Outdated
| @@ -320,7 +324,7 @@ export default class ColorPicker extends PureBaseComponent { | |||
| onChangeText={this.onChangeText} | |||
| style={[ | |||
| this.styles.input, | |||
| {color: textColor, width: (value.length + 1) * 16.5 * fontScale}, | |||
| {color: textColor, width: (value.length + 1) * 16.5 * fontScale, ...previewTextStyle}, | |||
There was a problem hiding this comment.
Don't spread the style, technically it can be a number that's pointing to a style.
the Input style is already constructed of an array, you can add it as another item of the array.
Also, consider passing it last, to give full control to the user.
ethanshar
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WOAUILIB-823)