Skip to content

CardSection support image (+ fix children counting in Card) #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2020
Merged

CardSection support image (+ fix children counting in Card) #813

merged 7 commits into from
Jun 16, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Jun 14, 2020 •
edited
Loading

  1. Card - fixed children's filter (change to getter)
  2. CardSection - now supports image + add testIDs
  3. CardsScreen - move to use only Card.Section + add some examples
  4. Fix some typings (including removing of Card.d.ts)

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar June 14, 2020 16:53
ethanshar
ethanshar reviewed Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
See my small comments

src/components/card/index.tsx
@@ -200,6 +200,14 @@ class Card extends PureComponent<PropTypes, State> {
return borderRadius === undefined ? DEFAULT_BORDER_RADIUS : borderRadius;
}

get children() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've created this getter but you forgot to use it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

M-i-k-e-l and others added 2 commits June 15, 2020 15:02
@M-i-k-e-l @ethanshar
Update src/components/card/CardSection.tsx
d67a61a 
Change testID from mainImage to image

Co-authored-by: Ethan Sharabi <[email protected]>
@M-i-k-e-l
Use childrens' getter
cf6e51b
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar June 15, 2020 12:36
@ethanshar ethanshar merged commit 730e12c into master Jun 16, 2020
@M-i-k-e-l M-i-k-e-l deleted the feat/card-section-support-image branch September 21, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar