Keyboard accessory view safe area api support #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anaged from a single place
…seSafeArea flag in the root params object instead of initialProps + fix documentation typo in ActionBar
M-i-k-e-l
reviewed
Jun 29, 2020
demo/src/screens/nativeComponentScreens/keyboardInput/KeyboardInputViewScreen.js
Outdated
Show resolved
Hide resolved
lib/components/Keyboard/KeyboardInput/CustomKeyboardViewBase.js
Outdated
Show resolved
Hide resolved
… toggle will be visible also for android devices to show users it won't effect other devices
…le is changed, the keyboard will re-appear with the right safe-area. applicable only for iOS devices
M-i-k-e-l
reviewed
Jul 5, 2020
|
|
||
| /** | ||
| * iOS only. | ||
| * Set false to allow the KeyboardAccessoryView to reach to the bottom of the screen, |
There was a problem hiding this comment.
The language is a bit cumbersome, I don't think you need to explain it in depth.
We have these two for other components:
- "Whether or not to handle SafeArea"
- "Use safe area, in case action bar attached to the bottom (default: true)"
Maybe something like:
"Whether or not to handle SafeArea
default: true"
M-i-k-e-l
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.