Skip to content

Fix button static values and other small type fixes #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2020
Merged

Fix button static values and other small type fixes #834

merged 9 commits into from
Jul 1, 2020

Conversation

ykravv
Copy link
Member

@ykravv ykravv commented Jun 30, 2020 •
edited
Loading

  • Now Button.sizes... works in TS
  • Commited missing changes to generatedTypes
  • Add common extractAccessibilityProps and getThemeProps types
  • Add AvatarProps to exports
  • Changed props to extend from TouchableOpacity not Text

@ykravv ykravv added the typescript typescript related issue label Jun 30, 2020
@ykravv ykravv requested a review from ethanshar June 30, 2020 18:57
@ykravv ykravv self-assigned this Jun 30, 2020
@ykravv ykravv changed the title Fix button static values Fix button static values and other small type fixes Jul 1, 2020
@ethanshar ethanshar merged commit 26e7c46 into master Jul 1, 2020
@ethanshar ethanshar deleted the fix-button-static-values branch January 22, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ykravv ykravv

Labels
typescript typescript related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykravv @ethanshar