Skip to content

Add prop types:backgroundColor to View and animate to Carousel #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Add prop types:backgroundColor to View and animate to Carousel #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
559dee7
Add 'backgroundColor' to 'View' and 'animate' to 'Carousel'
ykravv Jul 2, 2020
26c9667
Add 'goToPage' instance method to Carousel typings
ykravv Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions generatedTypes/components/view/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ export interface ViewPropTypes extends ViewProps, ContainerModifiers {
* Experimental: Pass time in ms to delay render
*/
renderDelay?: number;
/**
* Set background color
*/
backgroundColor?: string;
}
declare const _default: React.ComponentClass<ViewPropTypes, any>;
export default _default;
4 changes: 4 additions & 0 deletions src/components/view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ export interface ViewPropTypes extends ViewProps, ContainerModifiers {
* Experimental: Pass time in ms to delay render
*/
renderDelay?: number;
/**
* Set background color
*/
backgroundColor?: string;
}
type PropsTypes = BaseComponentInjectedProps & ForwardRefInjectedProps & ViewPropTypes;

Expand Down
5 changes: 4 additions & 1 deletion typings/components/Carousel.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ export interface CarouselProps {
autoplayInterval?: number;
style?: StyleProp<ViewStyle>;
children?: React.Node;
animated?: boolean;
}

export class Carousel extends BaseComponent<CarouselProps> {}
export class Carousel extends BaseComponent<CarouselProps> {
goToPage: (pageIndex: number) => void;
}