Skip to content

Feat/drawer left toggle #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 19, 2020
Merged

Feat/drawer left toggle #844

merged 8 commits into from
Jul 19, 2020

Conversation

Inbal-Tish
Copy link
Collaborator

Adding left toggle functionality

@Inbal-Tish Inbal-Tish requested a review from ethanshar July 7, 2020 09:39
@ethanshar ethanshar self-assigned this Jul 7, 2020
@ethanshar
Copy link
Collaborator

@Inbal-Tish
I didn't go over all the code cause I found some UI issues I think it's better to fix first.

First, the UI for right buttons is broken in this PR (the actions are not displayed horizontally but vertically)

Second,
I don't think the toggle works so good, something there is a little laggy.
If we need to compromise on the UX in order to make it work slicker so let's do it.
I think you can find a good, simple reference for toggle drawer in Gmail app

And one last thing, in the example screen, now it's impossible to see how the basic functionality works (when just opening the drawer and it stays open)

@ethanshar ethanshar requested review from ethanshar and removed request for ethanshar July 13, 2020 05:17
@Inbal-Tish
Copy link
Collaborator Author

oh my. Checking

@ethanshar ethanshar merged commit 7e35bcf into master Jul 19, 2020
@Inbal-Tish Inbal-Tish deleted the feat/Drawer_left_toggle branch July 20, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants