add numeric size support to Avatar's badge + unit-tests #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnonZ
reviewed
Jul 12, 2020
| const uut = new Avatar({badgeProps: {size: 0}}); | ||
| expect(uut.getBadgeSize()).toEqual(0); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Not the end of the world obviously but having 3 tests testing numeric input might be 2 tests too much 😸 .
If one of these tests fail, all of them will fail for the same reason.
For your consideration...
There was a problem hiding this comment.
right, keeping two for zero/undefined check + some number
ArnonZ
reviewed
Jul 13, 2020
src/components/avatar/index.tsx
Outdated
| const badgeSize = _.get(this.props, 'badgeProps.size', DEFAULT_BADGE_SIZE); | ||
|
|
||
| if (_.isString(badgeSize)) { | ||
| return BADGE_SIZES[badgeSize]; |
There was a problem hiding this comment.
When you split the logic between enum and numeric size you eliminated the fallback of DEFAULT_BADGE_SIZE for string-based sizes (currently returns undefined if sending a bad enum). Consider adding DEFAULT_BADGE_SIZE fallback if supplied enum size isn't included in BADGE_SIZES - to maintain old fallback logic.
ArnonZ
reviewed
Jul 13, 2020
…rding to default value change, removed redundant test.
ArnonZ
reviewed
Jul 19, 2020
fix typo Co-authored-by: Arnon <[email protected]>
ArnonZ
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added numeric value support for Avatar's badge size.